Skip to content

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

ssomers and others added 28 commits October 5, 2020 13:23
Replacing the UnsafeCell by a Cell simplifies things and makes it all
safe.
Replacing the UnsafeCell by a Cell makes it all safe.
This also allows 'rustdoc' as a string for the compiler profile.
Co-authored-by: varkor <[email protected]>
Fixes rust-lang#55890

It's useful to have `llc` and `opt` available when debugging an LLVM
miscompilation,.
Modern compilers allow reaching external crates
like std or core via relative paths in modules
outside of lib.rs and main.rs.
…ulacrum

BTreeMap: type-specific variants of node_as_mut and cast_unchecked

Improves debug checking and shortens some expressions. Extracted from rust-lang#77408
…mutex-attr-cleanup, r=Mark-Simulacrum

Remove unnecessary rustc_const_stable attributes.

These attributes were added in rust-lang#74033 (comment) because of [std::io::lazy::Lazy::new](https://github.com/rust-lang/rust/blob/0c03aee8b81185d65b5821518661c30ecdb42de5/src/libstd/io/lazy.rs#L21-L23). But [std::io::lazy::Lazy is gone now](rust-lang#77154), so this can be cleaned up.

@rustbot modify labels: +T-libs +C-cleanup
…ported-locks, r=Mark-Simulacrum

Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn).

Replacing `UnsafeCell`s by a `Cell`s simplifies things and makes the mutex and rwlock implementations safe. Other than that, only unsafety in strlen() contained unsafe code.

@rustbot modify labels: +F-unsafe-block-in-unsafe-fn +C-cleanup
 Give an error when running `x.py test --stage 0 src/test/ui`

The error can be overridden with `COMPILETEST_FORCE_STAGE0=1`. In practice I don't know why anyone would do this.

r? @Mark-Simulacrum

Closes rust-lang#77711
Mention rustdoc in `x.py setup`

This lets new contributors know which option they should pick; previously it wasn't clear 'compiler' also included rustdoc.

Unresolved questions: should this say 'compiler and tools' instead? I don't know of any tools that are modified in-tree other than rustdoc, though.

r? @Mark-Simulacrum
…stic, r=lcnr

`min_const_generics` diagnostics improvements

As disscussed in [zulip/project-const-generics/non-trivial anonymous constant](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/non-trivial.20anonymous.20constants).

This is my first PR on the compiler.

@lcnr is mentoring me on this PR.

Related to rust-lang#60551.
…k-Simulacrum

Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component

Fixes rust-lang#55890

It's useful to have `llc` and `opt` available when debugging an LLVM
miscompilation,.
Use Option::unwrap_or instead of open-coding it
…hs, r=lcnr

Replace absolute paths with relative ones

Modern compilers allow reaching external crates
like std or core via relative paths in modules
outside of lib.rs and main.rs.
…roalbini

Include aarch64-apple-darwin in the dist manifests

r? @ehuss

/cc @pietroalbini @Mark-Simulacrum
@JohnTitor
Copy link
Member Author

@bors r+ rollup=never p=5
@rustbot modify labels: rollup

@bors
Copy link
Collaborator

bors commented Oct 13, 2020

📌 Commit 02785e9 has been approved by JohnTitor

@rustbot rustbot added the rollup A PR which is a rollup label Oct 13, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 13, 2020
@bors
Copy link
Collaborator

bors commented Oct 13, 2020

⌛ Testing commit 02785e9 with merge 4f8979a5685c4ebfd1798726fb4485a4d0dd203d...

@bors
Copy link
Collaborator

bors commented Oct 13, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2020
@JohnTitor JohnTitor closed this Oct 13, 2020
@JohnTitor JohnTitor deleted the rollup-4047sqg branch October 13, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.